Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Jun 15, 2021

Resolves #380

@t-ober t-ober added the documentation Improvements or additions to documentation label Jun 15, 2021
@t-ober t-ober added this to the Version 2.1 milestone Jun 15, 2021
@t-ober t-ober requested review from ckittl and johanneshiry June 15, 2021 14:19
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #383 (1724e02) into dev (00c3b3a) will increase coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #383      +/-   ##
============================================
+ Coverage     77.76%   78.56%   +0.80%     
- Complexity     1922     2047     +125     
============================================
  Files           241      254      +13     
  Lines          7830     8124     +294     
  Branches        747      767      +20     
============================================
+ Hits           6089     6383     +294     
- Misses         1321     1353      +32     
+ Partials        420      388      -32     
Impacted Files Coverage Δ
.../java/edu/ie3/datamodel/utils/GridAndGeoUtils.java 66.66% <0.00%> (-24.25%) ⬇️
...atamodel/models/input/container/GridContainer.java 54.16% <0.00%> (-17.71%) ⬇️
...main/java/edu/ie3/datamodel/graph/SubGridGate.java 34.48% <0.00%> (-9.64%) ⬇️
...ls/timeseries/individual/IndividualTimeSeries.java 72.72% <0.00%> (-4.55%) ⬇️
...java/edu/ie3/datamodel/io/factory/FactoryData.java 47.22% <0.00%> (-4.40%) ⬇️
...3/datamodel/io/source/csv/CsvTimeSeriesSource.java 96.07% <0.00%> (-3.93%) ⬇️
...factory/result/SystemParticipantResultFactory.java 92.42% <0.00%> (-2.89%) ⬇️
...models/timeseries/repetitive/LoadProfileInput.java 40.90% <0.00%> (-2.57%) ⬇️
.../ie3/datamodel/io/source/sql/SqlWeatherSource.java 78.81% <0.00%> (-2.19%) ⬇️
...odel/io/source/influxdb/InfluxDbWeatherSource.java 87.77% <0.00%> (-0.73%) ⬇️
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f3b95...1724e02. Read the comment docs.

@johanneshiry johanneshiry merged commit 3796635 into dev Jun 16, 2021
@johanneshiry johanneshiry deleted the to/#380-null-handling-operation-time branch June 16, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend tests for AssetInputFactory to check for nulls and empty Strings as Input for optional fields

3 participants