Skip to content

Conversation

@ckittl
Copy link
Member

@ckittl ckittl commented Apr 6, 2021

Closes #316

@ckittl ckittl added the bug Something isn't working label Apr 6, 2021
@ckittl ckittl added this to the Version 2.0 milestone Apr 6, 2021
@ckittl ckittl requested a review from a team April 6, 2021 07:51
@ckittl ckittl self-assigned this Apr 6, 2021
Co-authored-by: Johannes Hiry <[email protected]>
@ckittl ckittl requested a review from johanneshiry April 6, 2021 15:03
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #319 (08121ab) into dev (eed20af) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #319      +/-   ##
============================================
+ Coverage     77.98%   78.04%   +0.05%     
- Complexity     1951     2102     +151     
============================================
  Files           249      257       +8     
  Lines          7936     8399     +463     
  Branches        749      814      +65     
============================================
+ Hits           6189     6555     +366     
- Misses         1321     1441     +120     
+ Partials        426      403      -23     
Impacted Files Coverage Δ Complexity Δ
.../java/edu/ie3/datamodel/utils/GridAndGeoUtils.java 66.66% <0.00%> (-24.25%) 2.00% <0.00%> (-12.00%)
...atamodel/models/input/container/GridContainer.java 54.16% <0.00%> (-17.71%) 8.00% <0.00%> (-2.00%)
...a/edu/ie3/datamodel/io/csv/FileNamingStrategy.java 91.97% <0.00%> (-5.83%) 49.00% <0.00%> (-4.00%)
...in/java/edu/ie3/datamodel/io/sink/CsvFileSink.java 74.39% <0.00%> (ø) 29.00% <0.00%> (ø%)
...n/java/edu/ie3/datamodel/io/sink/InfluxDbSink.java 79.27% <0.00%> (ø) 24.00% <0.00%> (ø%)
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 90.11% <0.00%> (ø) 54.00% <0.00%> (ø%)
...edu/ie3/datamodel/io/source/csv/CsvTypeSource.java 100.00% <0.00%> (ø) 13.00% <0.00%> (ø%)
.../ie3/datamodel/io/connectors/CsvFileConnector.java 77.38% <0.00%> (ø) 33.00% <0.00%> (ø%)
.../ie3/datamodel/io/source/csv/CsvWeatherSource.java 80.26% <0.00%> (ø) 20.00% <0.00%> (ø%)
...3/datamodel/io/source/csv/CsvTimeSeriesSource.java 96.07% <0.00%> (ø) 14.00% <0.00%> (ø%)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a760155...08121ab. Read the comment docs.

Co-authored-by: Johannes Hiry <[email protected]>
@ckittl ckittl requested a review from johanneshiry April 7, 2021 07:59
@johanneshiry johanneshiry merged commit dcccd30 into dev Apr 7, 2021
@johanneshiry johanneshiry deleted the ck/#316-removeDuplicateMethods branch April 7, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicated methods after update of PowerSystemUtils

3 participants