Skip to content

Conversation

@marvinheintze
Copy link
Contributor

Resolves #1287
Added error handling for getMapping() and added tests for the error handling

@marvinheintze marvinheintze self-assigned this Apr 7, 2025
@marvinheintze marvinheintze added the bug Something isn't working label Apr 7, 2025
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question from my side.

Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just improved the checking for errors a bit.

@staudtMarius staudtMarius merged commit 8e632ad into dev Apr 15, 2025
5 checks passed
@staudtMarius staudtMarius deleted the mh/#1287-time-series-mapping-error-handling branch April 15, 2025 12:34
@sebastian-peter sebastian-peter added this to the Version 7.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid time series mapping values just disappear

4 participants