Skip to content

Conversation

@marvinheintze
Copy link
Contributor

Resolves #1250
Replaced return this with return thisInstance() in CopyBuilders

# Conflicts:
#	CHANGELOG.md
#	src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
@marvinheintze marvinheintze self-assigned this Feb 28, 2025
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have two small requests.

Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more methods in SystemParticipantCopyBuilder, that are not using the thisInstance method.

@marvinheintze marvinheintze changed the title Mh/#1250 copy builders return this instance Copy builders return this instance Mar 11, 2025
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your work.

@staudtMarius staudtMarius merged commit a089adb into dev Mar 11, 2025
3 checks passed
@staudtMarius staudtMarius deleted the mh/#1250-CopyBuilders-return-thisInstance branch March 11, 2025 14:28
@sebastian-peter sebastian-peter added this to the Version 7.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor CopyBuilders to use thisInstance to return itself.

3 participants