-
Couldn't load subscription status.
- Fork 7
Copy builders return this instance #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have two small requests.
src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
Outdated
Show resolved
Hide resolved
…sInstance' into mh/#1250-CopyBuilders-return-thisInstance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more methods in SystemParticipantCopyBuilder, that are not using the thisInstance method.
src/main/java/edu/ie3/datamodel/models/input/container/JointGridContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/container/SubGridContainer.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/container/SystemParticipants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your work.
Resolves #1250
Replaced return this with return
thisInstance()in CopyBuilders