Adding CongestionResult.
#1098
Merged
Adding CongestionResult.
#1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested changes
Jun 13, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Just some small oversights I noticed
| import tech.units.indriya.ComparableQuantity; | ||
|
|
||
| public class CongestionResultFactory extends ResultEntityFactory<CongestionResult> { | ||
| private static final String SUBNET = "subnet"; |
Member
There was a problem hiding this comment.
We've been using grid instead of net for some time now, so I think it'd make sense to use subgrid here as well
Member
Author
There was a problem hiding this comment.
The NodeInput is still using net.
Member
There was a problem hiding this comment.
Yes, as in many other places. Should be changed at some point, but not here I'd say.
Member
Author
There was a problem hiding this comment.
Should I create a new issue for that?
Member
There was a problem hiding this comment.
Would be great, thanks!
src/main/java/edu/ie3/datamodel/utils/validation/UniquenessValidationUtils.java
Show resolved
Hide resolved
sebastian-peter
requested changes
Jun 13, 2024
Member
sebastian-peter
left a comment
sebastian-peter
left a comment
There was a problem hiding this comment.
Sorry, found more subnets
src/main/java/edu/ie3/datamodel/io/factory/result/CongestionResultFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/ResultEntitySource.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/UniquenessValidationUtilsTest.groovy
Outdated
Show resolved
Hide resolved
sebastian-peter
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1097