Improvements to finding corner points in IdCoordinateSource.
#1017
Conversation
…s-in-IdCoordinateSource
There was a problem hiding this comment.
Hmm. To be honest, I don't get the point. You're separating the functionality into two methods - ok, fine. But this is not more efficient, actually.
Now we're calculating distances.stream().filter(c -> !corners.contains(c)) on top of what we've been doing before. This had been part of the List<CoordinateDistance> other before.
…s-in-IdCoordinateSource
|
My idea with this PR is to have the part of finding the corners to be accessible from outside. But I see your point. I changed it with the next commit. I also added a method that can be used to just return the corner points or an exact matching point. The reason for this is, that in SIMONA we get a list of points, that may contain only our corner points, and then we calculate the corner points again. Edit SP: ie3-institute/simona#625 |
…-corner-points-in-IdCoordinateSource' into ms/#1016-improvements-to-finding-corner-points-in-IdCoordinateSource
…s-in-IdCoordinateSource # Conflicts: # CHANGELOG.md
…s-in-IdCoordinateSource
…s-in-IdCoordinateSource # Conflicts: # src/main/java/edu/ie3/datamodel/io/source/IdCoordinateSource.java
…s-in-IdCoordinateSource
…s-in-IdCoordinateSource
…s-in-IdCoordinateSource
…s-in-IdCoordinateSource
…s-in-IdCoordinateSource
docs/readthedocs/models/input/additionaldata/idcoordinatesource.md
Outdated
Show resolved
Hide resolved
danielfeismann
deleted the
ms/#1016-improvements-to-finding-corner-points-in-IdCoordinateSource
branch
Resolves #1016