-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Labels
code qualityCode readability or structure is improvedCode readability or structure is improved
Description
What I think this should look like is *Connectors taking care of operations close to the file system, and *DataSource handling higher-level decisions, i.e. where data is stored (paths/databases/etc.). With SqlConnector and SqlDataSource, this division is already in place.
Illustrating the desired change with examples in two areas:
- Different exception handling
CsvConnectorshould then throw (or return withinTrys)ConnectorExceptions, andCsvDataSourceshould throw (or return withinTrys)SourceExceptions. - Separate
FileNamingStrategyfromCsvFileConnector
Currently,CsvFileConnectoruses theFileNamingStrategyto determine paths of some entities. This is happening less with CsvDataSource should throw exceptions on error. #999, and should arguably move toCsvDataSourceanyways.CsvFileConnectorshould not care where a path comes from, it should just deal with it.
Metadata
Metadata
Assignees
Labels
code qualityCode readability or structure is improvedCode readability or structure is improved