Skip to content

Refactoring CsvFileConnector and CsvDataSource #1007

@sebastian-peter

Description

@sebastian-peter

What I think this should look like is *Connectors taking care of operations close to the file system, and *DataSource handling higher-level decisions, i.e. where data is stored (paths/databases/etc.). With SqlConnector and SqlDataSource, this division is already in place.

Illustrating the desired change with examples in two areas:

  • Different exception handling
    CsvConnector should then throw (or return within Trys) ConnectorExceptions, and CsvDataSource should throw (or return within Trys) SourceExceptions.
  • Separate FileNamingStrategy from CsvFileConnector
    Currently, CsvFileConnector uses the FileNamingStrategy to determine paths of some entities. This is happening less with CsvDataSource should throw exceptions on error. #999, and should arguably move to CsvDataSource anyways. CsvFileConnector should not care where a path comes from, it should just deal with it.

Metadata

Metadata

Assignees

Labels

code qualityCode readability or structure is improved

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions