zip: finish stream async when async #808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the async finishing of entries in
ZipOutputStream. The initial problem was that there was a sneakybase.Finish()call inWriteEntryFooterwhich in turn wrote synchronously to the output stream when called.Additionally,
DeflateOutputSteam.AsyncDisposewas not included when targeting .NET 6 due to the preprocessor constants forNETSTANDARD2_1_OR_GREATERnot being defined.This also adds tests that ensures that writing zip streams can be done wholly async, without calling any of the output streams synchronous methods.
Fixes #801
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.