Skip to content

Conversation

@piksel
Copy link
Member

@piksel piksel commented Oct 9, 2021

This replaces all usage of Random in the tests with deterministic pseudo random data that should yield the same coverage regardless of runs and if new tests are added (which was the case before).

It also refactors and homogenize the tests a bit, with clearer asserts and labels for non-obvious arguments.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #671 (a55f226) into master (b5b1a92) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   73.07%   73.31%   +0.24%     
==========================================
  Files          68       68              
  Lines        8305     8305              
==========================================
+ Hits         6069     6089      +20     
+ Misses       2236     2216      -20     
Impacted Files Coverage Δ
...ode.SharpZipLib/Zip/Compression/DeflaterHuffman.cs 97.87% <0.00%> (+6.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b1a92...a55f226. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants