Skip to content

Conversation

@piksel
Copy link
Member

@piksel piksel commented Nov 10, 2020

Use a proper RNG for cryptographically important randomness.
Fixes #536

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy
Copy link
Contributor

Numpsy commented Nov 10, 2020

Is it intentional that the RNGCryptoServiceProvider is disposed in two of those changes, but not the third?

@piksel
Copy link
Member Author

piksel commented Nov 10, 2020

Is it intentional that the RNGCryptoServiceProvider is disposed in two of those changes, but not the third?

Noope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random() is not secure because it provides insufficient entropy. CWE ID 331.

3 participants