convert property in array type #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icebob
requested changes
Dec 1, 2022
| const src = []; | ||
|
|
||
| let sanitized = false; | ||
| if (schema.convert === true) { |
Owner
There was a problem hiding this comment.
I think we shouldn't have to wrap the null and undefined values because they are no "real" values.
The current implementation will wrap the { roles: null } to { roles: [null] }
test/rules/array.spec.js
Outdated
| it("should wrap single value into array", () => { | ||
| const check = v.compile({ $$root: true, type: "array", items: "string", convert: true }); | ||
| expect(check("a")).toEqual(true); | ||
| }); |
Owner
There was a problem hiding this comment.
Please add more test, to check the santitized value as well, and add test when the input:
- an array with value,
- an empty array
- null
- undefined
Author
|
Added null and undefined checks + deep tests as requested. The tests have been moved to the "Sanitizations" describe section as it was more meaningful based on the context |
Owner
|
Please note, I changed the nullish check to a simpler one because in this lib we aim to be the fastest, and creating an array for the check is very expensive:
By the way, thank you for your contribution! |
Owner
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.