Skip to content

Conversation

intech
Copy link
Contributor

@intech intech commented Dec 13, 2019

No description provided.

@intech intech changed the title add unique valudation in array rule add unique valшdation in array rule Dec 13, 2019
@intech intech changed the title add unique valшdation in array rule add unique validation in array rule Dec 13, 2019
@intech
Copy link
Contributor Author

intech commented Dec 16, 2019

@icebob I updated everything to the latest version.

I missed and my fork lagged behind such global code changes.

@coveralls
Copy link

coveralls commented Dec 16, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 72533e9 on intech:master into f2af4dd on icebob:master.


if (schema.unique === true) {
src.push(`
if(len > Array.from(new Set(value)).length) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Set has a size property, no need to convert it back the array for length. Please update it.

Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good job.

@icebob icebob merged commit 0f1bd38 into icebob:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants