-
Notifications
You must be signed in to change notification settings - Fork 247
GetOccurrences(): Fix NPE when returning a ToDo's occurrences that don't have a duration #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and no duration
…Start` but without a duration
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (68%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #826 +/- ##
===================================
Coverage 68% 68%
===================================
Files 106 106
Lines 4209 4209
Branches 945 945
===================================
Hits 2842 2842
Misses 1039 1039
Partials 328 328
🚀 New features to boost your workflow:
|
axunonb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing and including this important test case



TODO's don't necessarily have a duration, so the occurrences returned by
GetOccurrencesmay return anEffectiveDurationofnull. Such cases caused an NPE that is fixed with this PR.fixes #824