Remove redundant Equals and GetHashCode implementations
#810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de overrides, IComparable<AlarmOccurrence>
minichma
previously approved these changes
May 31, 2025
Collaborator
minichma
left a comment
minichma
left a comment
There was a problem hiding this comment.
LGTM. JFYI, I tried to set breakpoints on the main branch in the methods being removed by this branch and ran the updated unit tests. There are still quite some invocations throughout the test cases, mostly comparing some components for equality or adding them to HashSets. Not sure any of them need to be updated.
|
Collaborator
Author
Thanks for the review. Indeed there were a some of tests left to be removed using |
axunonb
added a commit
to axunonb/ical.net
that referenced
this pull request
Jun 4, 2025
…#810) * `Calendar`: Remove Equals and GetHashCode overrides * `CalendarEvent`: Remove Equals and GetHashCode overrides * `CalendarCollection`: Remove Equals and GetHashCode overrides * `RecurringComponent`: Remove Equals and GetHashCode overrides * `Journal`: Remove Equals and GetHashCode overrides * `AlarmOccurrence` (`RecurringComponent`): Remove Equals and GetHashCode overrides, IComparable<AlarmOccurrence> * `Attachment`: Remove Equals and GetHashCode overrides * `Attendee`: Remove Equals and GetHashCode overrides * `GeographicLocation`: Remove Equals and GetHashCode overrides * `Organizer`, `PeriodList`: Remove Equals and GetHashCode overrides * `RecurrencePattern`: Remove Equals and GetHashCode overrides * `Trigger`: Remove Equals and GetHashCode overrides * `VTimeZoneInfo`: Remove Equals and GetHashCode overrides * Remove remaining test with explict calls to `Equals` and `GetHashCode`
axunonb
added a commit
to axunonb/ical.net
that referenced
this pull request
Jun 5, 2025
…#810) * `Calendar`: Remove Equals and GetHashCode overrides * `CalendarEvent`: Remove Equals and GetHashCode overrides * `CalendarCollection`: Remove Equals and GetHashCode overrides * `RecurringComponent`: Remove Equals and GetHashCode overrides * `Journal`: Remove Equals and GetHashCode overrides * `AlarmOccurrence` (`RecurringComponent`): Remove Equals and GetHashCode overrides, IComparable<AlarmOccurrence> * `Attachment`: Remove Equals and GetHashCode overrides * `Attendee`: Remove Equals and GetHashCode overrides * `GeographicLocation`: Remove Equals and GetHashCode overrides * `Organizer`, `PeriodList`: Remove Equals and GetHashCode overrides * `RecurrencePattern`: Remove Equals and GetHashCode overrides * `Trigger`: Remove Equals and GetHashCode overrides * `VTimeZoneInfo`: Remove Equals and GetHashCode overrides * Remove remaining test with explict calls to `Equals` and `GetHashCode` Remove redundant `Equals` and `GetHashCode` implementations (ical-org#810) * `Calendar`: Remove Equals and GetHashCode overrides * `CalendarEvent`: Remove Equals and GetHashCode overrides * `CalendarCollection`: Remove Equals and GetHashCode overrides * `RecurringComponent`: Remove Equals and GetHashCode overrides * `Journal`: Remove Equals and GetHashCode overrides * `AlarmOccurrence` (`RecurringComponent`): Remove Equals and GetHashCode overrides, IComparable<AlarmOccurrence> * `Attachment`: Remove Equals and GetHashCode overrides * `Attendee`: Remove Equals and GetHashCode overrides * `GeographicLocation`: Remove Equals and GetHashCode overrides * `Organizer`, `PeriodList`: Remove Equals and GetHashCode overrides * `RecurrencePattern`: Remove Equals and GetHashCode overrides * `Trigger`: Remove Equals and GetHashCode overrides * `VTimeZoneInfo`: Remove Equals and GetHashCode overrides * Remove remaining test with explict calls to `Equals` and `GetHashCode`
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar: Remove Equals and GetHashCode overridesCalendarEvent(RecurringComponent): Remove Equals and GetHashCode overridesCalendarCollection: Remove Equals and GetHashCode overridesRecurringComponent: Remove Equals and GetHashCode overridesJournal(RecurringComponent): Remove Equals and GetHashCode overridesAlarm(RecurringComponent): Remove Equals and GetHashCode overridesVTimeZone(RecurringComponent): Remove Equals and GetHashCode overridesAlarmOccurrence(RecurringComponent): Remove Equals and GetHashCode overrides, IComparableAttachment: Remove Equals and GetHashCode overridesAttendee: Remove Equals and GetHashCode overridesGeographicLocation: Remove Equals and GetHashCode overridesOrganizer: Remove Equals and GetHashCode overridesPeriodList: Remove Equals and GetHashCode overridesRecurrencePattern: Remove Equals and GetHashCode overridesTrigger: Remove Equals and GetHashCode overridesVTimeZoneInfo: Remove Equals and GetHashCode overridesResolves #274