Fix: CalendarComponent.AddProperty adds the CalendarProperty
#801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, only the `CalendarProperty.Value` was added. Resolves #797
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #801 +/- ##
===================================
Coverage 67% 67%
===================================
Files 106 106
Lines 4421 4421
Branches 1060 1060
===================================
+ Hits 2942 2943 +1
+ Misses 1042 1041 -1
Partials 437 437
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
axunonb
force-pushed
the
wip/axunonb/pr/fix-calendarcomponent-addproperty
branch
from
9893ad0 to
d7b3ef1
Compare
Remove duplicate of the test from SimpleDeserializationTests
axunonb
commented
May 18, 2025
| Assert.That(propDescription.Parameters.FirstOrDefault(p => p.Name == "FMTTYPE")!.Value, Is.EqualTo("text/html")); | ||
|
|
||
| Assert.That(propProjects.Parameters, Has.Count.EqualTo(2), "Parameter list should have 2 elements"); | ||
| Assert.That(propProjects.Value, Is.EqualTo("ProjectA,ProjectB")); |
Collaborator
Author
There was a problem hiding this comment.
Should propProject.Values be a list containing ProjectA and ProjectB as elements?
minichma
approved these changes
May 18, 2025
|
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, only the
CalendarProperty.Valuewas added, andCalendarProperty.Parametersand other properties got lost.Resolves #797