Fix positive/nagative args in Duration CTOR
#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #767 +/- ##
===================================
Coverage 67% 67%
===================================
Files 104 104
Lines 4494 4499 +5
Branches 1113 1113
===================================
+ Hits 2996 3003 +7
+ Misses 1068 1066 -2
Partials 430 430
🚀 New features to boost your workflow:
|
axunonb
force-pushed
the
axunonb/wip/pr/fix-issue-766
branch
from
2e01d65 to
85bb993
Compare
minichma
reviewed
Apr 11, 2025
axunonb
force-pushed
the
axunonb/wip/pr/fix-issue-766
branch
from
85bb993 to
b2bd9f6
Compare
minichma
previously approved these changes
Apr 11, 2025
| [TestCase("-P0DT0H30M0S", 0, 0, 0, -30, 0)] | ||
| [TestCase("-P1DT1H", 0, -1, -1, 0, 0)] | ||
| [TestCase("P", null, null, null, null, null)] // Empty duration | ||
| [TestCase("PT", null, null, null, null, null)] // Empty time |
Collaborator
Author
There was a problem hiding this comment.
P and PT are not, I'll remove it for clarity
Collaborator
|
Great! Thank you for fixing this! |
* Updated the `Duration` to identify the expected sign for args correctly * Added new test cases for `DurationSerializer` to validate various duration formats and handle invalid arguments. Fixes #766
axunonb
force-pushed
the
axunonb/wip/pr/fix-issue-766
branch
from
b2bd9f6 to
16aed0b
Compare
|
axunonb
changed the title
Duration handlingDuration CTOR
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Durationstruct for improved argument validation and error messagingAlarmTest.csforDurationSerializerto validate various duration formats and handle invalid arguments.Fixes #766