Make CalendarEvent.EffectiveDuration and some conversion functions public.
#733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (66%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #733 +/- ##
===================================
Coverage 66% 66%
===================================
Files 103 103
Lines 4644 4645 +1
Branches 1152 1152
===================================
+ Hits 3064 3065 +1
Misses 1144 1144
Partials 436 436
|
minichma
force-pushed
the
work/minichma/effectiveduration_public
branch
from
664e1aa to
e13dcbe
Compare
|
axunonb
reviewed
Feb 16, 2025
| /// To convert a duration to a <see cref="TimeSpan"/> while considering the days and weeks as | ||
| /// nominal durations, use <see cref="ToTimeSpan"/>. | ||
| /// </remarks> | ||
| public TimeSpan ToTimeSpanUnspecified() |
Collaborator
There was a problem hiding this comment.
Yep, this was a missing part, agree.
axunonb
approved these changes
Feb 16, 2025
Collaborator
axunonb
left a comment
axunonb
left a comment
There was a problem hiding this comment.
This all makes sense, very good
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some relevant functions public, including
CalendarEvent.EffectiveDurationDuration.ToTimeSpanUnspecified()Duration.ToTimeSpan()Duration.FromTimeSpanExact()Relates to the conversation in #606 (comment).