IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Jul 22, 2024
|
Reported PHPStan error is valid. We need to address it. |
|
Update: new changes: 758d193...193cbdd |
alongosz
force-pushed
the
ibx-8138-symfony-5-rule-sets
branch
3 times, most recently
from
f140e48 to
2a64281
Compare
adamwojs
approved these changes
Aug 17, 2024
alongosz
force-pushed
the
ibx-8138-symfony-5-rule-sets
branch
from
2a64281 to
901df53
Compare
Applied rules: * AddReturnTypeDeclarationRector * AnnotationToAttributeRector * RedirectToRouteRector * RemoveUnusedRequestParamRector * RenameClassConstFetchRector * ResponseStatusCodeRector
Applied rules: * RenameClassConstFetchRector
alongosz
force-pushed
the
ibx-8138-symfony-5-rule-sets
branch
from
901df53 to
9ea759d
Compare
|
mikadamczyk
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Applied rules from Symfony 5 Rector set lists.
For QA:
No QA needed. Regression tests should be enough.
Documentation:
This is code refactoring without behavior change. No documentation changes needed.