Skip to content

Fix S3442 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Fix S3442 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63d4e3a
Fix S3442
iamdmitrij Apr 30, 2024
df8b126
Fix linting error
iamdmitrij Apr 30, 2024
d2ed315
Merge branch 'main' into S3442
iamdmitrij Apr 30, 2024
704f1ca
Merge branch 'main' into S3442
iamdmitrij Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Polly/AsyncPolicy.TResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public abstract partial class AsyncPolicy<TResult> : PolicyBase<TResult>
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle. </param>
/// <param name="resultPredicates">Predicates indicating which results the policy should handle. </param>
internal AsyncPolicy(
private protected AsyncPolicy(
ExceptionPredicates exceptionPredicates,
ResultPredicates<TResult> resultPredicates)
: base(exceptionPredicates, resultPredicates)
Expand Down
2 changes: 1 addition & 1 deletion src/Polly/AsyncPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public abstract partial class AsyncPolicy
/// Initializes a new instance of the <see cref="AsyncPolicy"/> class.
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle. </param>
internal AsyncPolicy(ExceptionPredicates exceptionPredicates)
private protected AsyncPolicy(ExceptionPredicates exceptionPredicates)
: base(exceptionPredicates)
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/Polly/Policy.TResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public abstract partial class Policy<TResult> : PolicyBase<TResult>
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle.</param>
/// <param name="resultPredicates">Predicates indicating which results the policy should handle.</param>
internal Policy(ExceptionPredicates exceptionPredicates, ResultPredicates<TResult> resultPredicates)
private protected Policy(ExceptionPredicates exceptionPredicates, ResultPredicates<TResult> resultPredicates)
: base(exceptionPredicates, resultPredicates)
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/Polly/Policy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public abstract partial class Policy : PolicyBase
/// Initializes a new instance of the <see cref="Policy"/> class.
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle. </param>
internal Policy(ExceptionPredicates exceptionPredicates)
private protected Policy(ExceptionPredicates exceptionPredicates)
: base(exceptionPredicates)
{
}
Expand Down
4 changes: 2 additions & 2 deletions src/Polly/PolicyBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ internal static ExceptionType GetExceptionType(ExceptionPredicates exceptionPred
/// Initializes a new instance of the <see cref="PolicyBase"/> class.
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle. </param>
internal PolicyBase(ExceptionPredicates exceptionPredicates) =>
private protected PolicyBase(ExceptionPredicates exceptionPredicates) =>
ExceptionPredicates = exceptionPredicates ?? ExceptionPredicates.None;

/// <summary>
Expand Down Expand Up @@ -62,7 +62,7 @@ public abstract class PolicyBase<TResult> : PolicyBase
/// </summary>
/// <param name="exceptionPredicates">Predicates indicating which exceptions the policy should handle. </param>
/// <param name="resultPredicates">Predicates indicating which results the policy should handle. </param>
internal PolicyBase(
private protected PolicyBase(
ExceptionPredicates exceptionPredicates,
ResultPredicates<TResult> resultPredicates)
: base(exceptionPredicates) =>
Expand Down
2 changes: 1 addition & 1 deletion src/Polly/Polly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<NoWarn>$(NoWarn);S3872;SA1402;SA1414;S3215</NoWarn>
<NoWarn>$(NoWarn);IDE1006;CA1062;CA1068;S4039;CA1063;CA1031;CA1051</NoWarn>
<NoWarn>$(NoWarn);CA2211;S2223;CA1032;CA1815;CA1816;S4457;SA1615;CA1033</NoWarn>
<NoWarn>$(NoWarn);CA1010;S3442;CA1064;SA1623;SA1118</NoWarn>
<NoWarn>$(NoWarn);CA1010;CA1064;SA1623;SA1118</NoWarn>
<NoWarn>$(NoWarn);S3971;CA1724;CA1716;SA1108;CA1710;S4049;S3246</NoWarn>
<NoWarn>$(NoWarn);CA1805</NoWarn>

Expand Down