Omit paragraph wrappers from list item text #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the style of `list_item` to match the format from https://www.markdownguide.org/basic-syntax/#lists-1 Namely, that `list_item` contents do not have vertical margin due to wrapped `paragraph` tokens. If folks do want this behavior, they can override the style of `*_list_icon` or `*_list_content`. This change has the added benefit of eliminating the need for platform specific `*_list_icon` margins and line heights. Horray! iOS before: <img width="433" alt="list_ios_before" src="https://user-images.githubusercontent.com/456610/89119457-90897600-d463-11ea-80a7-05ea6e86f4a5.png"> iOS after: <img width="441" alt="list_ios_after" src="https://user-images.githubusercontent.com/456610/89119465-94b59380-d463-11ea-8f4c-161fbb43e6a6.png"> Android before: <img width="356" alt="list_android_before" src="https://user-images.githubusercontent.com/456610/89119470-98491a80-d463-11ea-8415-31374584603d.png"> Android after: <img width="357" alt="list_android_after" src="https://user-images.githubusercontent.com/456610/89119474-9c753800-d463-11ea-98d9-07b4e1585b44.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
This updates the style of
list_itemto match the format from https://www.markdownguide.org/basic-syntax/#lists-1Namely, that
list_itemcontents do not have vertical margin due to wrappedparagraphtokens.If folks do want this behavior, they can override the style of
*_list_iconor*_list_content.This change has the added benefit of eliminating the need for platform specific
*_list_iconmargins and line heights. Horray!iOS before:
iOS after:
Android before:
Android after:
