Skip to content

Fix NullReferenceException in LastSemester by adding null check and p… #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NullReferenceException in LastSemester by adding null check and p… #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ProStudCreator/SemesterExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static Semester AfterNextSemester(ProStudentCreatorDBDataContext db)
public static Semester LastSemester(ProStudentCreatorDBDataContext db)
{
var currentSemester = ActiveSemester(DateTime.Now, db);
var safeDate = currentSemester.StartDate.AddDays(-7);
var safeDate = currentSemester.StartDate.AddDays(-7);
return ActiveSemester(safeDate, db);
}

Expand Down Expand Up @@ -72,7 +72,9 @@ public static Semester AfterNextSemester(Semester semester, ProStudentCreatorDBD

public static Semester LastSemester(Semester semester, ProStudentCreatorDBDataContext db)
{
return ActiveSemester(semester.StartDate.AddDays(-7), db);
if (semester == null) return null;
var probe = semester.StartDate.AddDays(-7).AddSeconds(-1);
return ActiveSemester(probe, db);
}

public static Semester ActiveSemester(DateTime date, ProStudentCreatorDBDataContext db)
Expand Down