Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Styling for disabled input.

Testing

Tested manually. UTs added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner July 6, 2021 13:43
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #976 (548ea18) into main (05b0dce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         812      812           
  Lines       16742    16744    +2     
  Branches     2165     2166    +1     
=======================================
+ Hits        14238    14240    +2     
  Misses       2473     2473           
  Partials       31       31           
Impacted Files Coverage Δ
projects/components/src/input/input.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b0dce...548ea18. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 07e9821 into main Jul 6, 2021
@arjunlalb arjunlalb deleted the disabled-input-style branch July 6, 2021 14:48
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   15m 56s ⏱️ + 1m 47s
938 tests ±0  938 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
944 runs  ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 07e9821. ± Comparison against base commit 05b0dce.

}
}

public getStyleClasses(): string[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not create a style property that we update whenever appearance or disabled changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants