Skip to content

feat: expose replaceHistory option via navigable tab component #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2021
Merged

feat: expose replaceHistory option via navigable tab component #887

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fe0fa2
feat: expose replaceHistory option via navigable tab component
arjunlalb May 28, 2021
36dffa6
Merge branch 'main' into replace-history-in-navigable-tab
arjunlalb May 28, 2021
49a5db7
fix: use ht-link in tab component
arjunlalb May 29, 2021
c002114
Merge branch 'replace-history-in-navigable-tab' of github.com:hypertr…
arjunlalb May 29, 2021
3c51f24
fix: minor changes
arjunlalb May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions projects/common/src/navigation/navigation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,15 @@ export class NavigationService {
public navigateWithinApp(
path: NavigationPath,
relativeTo?: ActivatedRoute,
preserveParameters?: string[]
preserveParameters?: string[],
replaceCurrentHistory?: boolean
): Observable<boolean> {
return this.navigate({
navType: NavigationParamsType.InApp,
path: path,
queryParams: this.buildQueryParam(preserveParameters ?? []),
relativeTo: relativeTo
relativeTo: relativeTo,
replaceCurrentHistory: replaceCurrentHistory
});
}

Expand Down
2 changes: 1 addition & 1 deletion projects/components/src/tabs/navigable/navigable-tab-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class NavigableTabGroupComponent implements AfterContentInit {
});

public onTabClick(tab: NavigableTabComponent): void {
this.navigationService.navigateWithinApp([tab.path], this.activatedRoute);
this.navigationService.navigateWithinApp([tab.path], this.activatedRoute, [], tab.replaceHistory);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did i accidentally forget to remove it? This function shouldn't be used. We need to add this option to the buildNavigationParams

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is nested inside an ht-link and should be deleted here and in the template

Copy link
Contributor Author

@arjunlalb arjunlalb May 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandtiwary fixed this. Used ht-link in the component instead of hyperlink.

}

private findActiveTab(): NavigableTabComponent | undefined {
Expand Down
3 changes: 3 additions & 0 deletions projects/components/src/tabs/navigable/navigable-tab.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ export class NavigableTabComponent extends ContentHolder {
@Input()
public hidden: boolean = false;

@Input()
public replaceHistory?: boolean;

@Input()
public features: string[] = [];

Expand Down
1 change: 1 addition & 0 deletions projects/components/src/tabs/navigable/navigable-tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ export interface NavigableTab {
label: string;
hidden?: boolean;
features?: string[];
replaceHistory?: boolean;
}