Skip to content

feat: adding note icon #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2021
Merged

feat: adding note icon #801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440501b
feat: adding note icon
itssharmasandeep Apr 26, 2021
031e345
fix: removing unwanted code
itssharmasandeep Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions projects/assets-library/assets/icons/note.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-library.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const iconsRootPath = 'assets/icons';
{ key: IconType.MoreVertical, url: `${iconsRootPath}/more-vertical.svg` },
{ key: IconType.NoData, url: `${iconsRootPath}/no-data.svg` },
{ key: IconType.Node, url: `${iconsRootPath}/node.svg` },
{ key: IconType.Note, url: `${iconsRootPath}/note.svg` },
{ key: IconType.OpenInNewTab, url: `${iconsRootPath}/open-in-new-tab.svg` },
{ key: IconType.Search, url: `${iconsRootPath}/search.svg` },
{ key: IconType.SidebarCollapse, url: `${iconsRootPath}/sidebar-collapse.svg` },
Expand Down
2 changes: 2 additions & 0 deletions projects/assets-library/src/icons/icon-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const enum IconType {
Dashboard = 'svg:dashboard',
Debug = 'bug_report',
Delete = 'delete',
Description = 'svg:page',
Device = 'svg:device',
Done = 'done',
Edge = 'edge',
Expand Down Expand Up @@ -78,6 +79,7 @@ export const enum IconType {
NoData = 'svg:noData',
Node = 'node',
None = 'none',
Note = 'svg:note',
Copy link
Contributor

@arjunlalb arjunlalb Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both svgs page and note looks to be the same. If it already exists, could we reuse that and avoiding a new note icon?

Copy link
Contributor Author

@itssharmasandeep itssharmasandeep Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are same, I liked note better name for that icon and more generic as it is used as description icon in the security tab inside settings.
I will be changing that on the traceable side once this is merged.

OpenInNewTab = 'svg:open-in-new-tab',
PageView = 'pageview',
Previous = 'navigate_before',
Expand Down