Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Remove pointer on table unless the row is selectable (cells already apply a pointer style if clickable)

Testing

Visual

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner April 24, 2021 01:23
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #793 (ff40658) into main (9e94511) will increase coverage by 0.20%.
The diff coverage is 87.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   85.21%   85.42%   +0.20%     
==========================================
  Files         773      792      +19     
  Lines       15941    16169     +228     
  Branches     2055     2062       +7     
==========================================
+ Hits        13584    13812     +228     
- Misses       2323     2326       +3     
+ Partials       34       31       -3     
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)
...ects/components/src/beta-tag/beta-tag.component.ts 100.00% <ø> (ø)
...omponents/src/breadcrumbs/breadcrumbs.component.ts 94.11% <ø> (ø)
...mponents/src/expander/expander-toggle.component.ts 100.00% <ø> (ø)
...omponents/src/header/page/page-header.component.ts 100.00% <ø> (ø)
...nents/src/menu-dropdown/menu-dropdown.component.ts 100.00% <ø> (ø)
projects/components/src/modal/modal.ts 100.00% <ø> (ø)
...ents/src/navigation/nav-item/nav-item.component.ts 100.00% <ø> (ø)
...onents/src/navigation/navigation-list.component.ts 85.18% <ø> (ø)
...ts/components/src/paginator/paginator.component.ts 95.08% <ø> (ø)
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3722a76...ff40658. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit ecc797f into main Apr 24, 2021
@aaron-steinfeld aaron-steinfeld deleted the pointer-on-selectable branch April 24, 2021 02:29
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 7s ⏱️ -31s
897 tests ±0  897 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
903 runs  ±0  903 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ecc797f. ± Comparison against base commit 3722a76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants