Skip to content

feat: adding new filter icon #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2021
Merged

feat: adding new filter icon #1185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62cb8d
feat: adding new filter icon
Oct 11, 2021
1d5b52a
feat: icon renamed
Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/assets-library/assets/icons/filter-special.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-library.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const iconsRootPath = 'assets/icons';
{ key: IconType.Eye, url: `${iconsRootPath}/eye.svg` },
{ key: IconType.FileCode, url: `${iconsRootPath}/file-code.svg` },
{ key: IconType.Filter, url: `${iconsRootPath}/filter.svg` },
{ key: IconType.FilterSpecial, url: `${iconsRootPath}/filter-special.svg` },
Copy link
Contributor

@jake-bassett jake-bassett Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would we use this filter icon instead of the other one?

Copy link
Contributor Author

@palbizu palbizu Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the mocks, should I keep the old filter icon here or replace it with the new-one?

Copy link
Contributor

@anandtiwary anandtiwary Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we using the existing filter icon? Can you share what it looks like?

Copy link
Contributor Author

@palbizu palbizu Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using a button. Just in the tables but here a similar example in an input
image

Copy link
Contributor

@jake-bassett jake-bassett Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I could see us needing both as we have different types of filtering, but was curious about the distinction so we could find a better name.

Let's go ahead and merge this with the current name. Once we get a feel for the UX usage, we should rename.

Copy link
Contributor

@arjunlalb arjunlalb Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could rename the existing one to 'drilldown-filter'. That is the purpose of that icon in the UI now.

Copy link
Contributor Author

@palbizu palbizu Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @arjunlalb. Icon renamed.

{ key: IconType.Go, url: `${iconsRootPath}/go.svg` },
{ key: IconType.Helm, url: `${iconsRootPath}/helm.svg` },
{ key: IconType.Hypertrace, url: `${iconsRootPath}/hypertrace.svg` },
Expand Down
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const enum IconType {
Favorite = 'favorite_border',
FileCode = 'svg:file-code',
Filter = 'svg:filter',
FilterSpecial = 'svg:filter-special',
First = 'first_page',
Go = 'svg:go',
Helm = 'svg:helm',
Expand Down