Increase default debounce #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 85.08% 85.08% -0.01%
==========================================
Files 822 822
Lines 16931 16924 -7
Branches 2045 2045
==========================================
- Hits 14406 14399 -7
Misses 2494 2494
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
previously approved these changes
Aug 18, 2021
anandtiwary
reviewed
Aug 18, 2021
| this.checkboxDiffer = this.differFactory.find([]).create(); | ||
|
|
||
| this.subscriptionLifecycle.add( | ||
| this.searchDebounceSubject.pipe(debounceTime(200)).subscribe(text => this.searchChange.emit(text)) |
There was a problem hiding this comment.
We can really use the ootb debounceTime property of search box component. Additional subscription here is not required in this table.
Please update the time in search box component as well either ways
There was a problem hiding this comment.
ah yeah I forgot we added that - switched over to using that one (searchbox doesn't have a built in time, it's not debouncing by default)
jake-bassett
approved these changes
Aug 18, 2021
anandtiwary
approved these changes
Aug 18, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update table search debounce from 200ms to 400ms to reduce api calls.
Testing
Manual, updated UT
Checklist:
#1072