Skip to content

feat: add esnext.string to ts libs #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021
Merged

feat: add esnext.string to ts libs #1013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b4bf4d
feat: add esnext.string to ts libs
jake-bassett Jul 20, 2021
2fc95e7
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into esnex…
jake-bassett Jul 20, 2021
5dcb859
style: prettier
jake-bassett Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"noUnusedLocals": true,
"noUnusedParameters": true,
"downlevelIteration": true,
"lib": ["es2015", "es2016", "es2017", "esnext.array", "esnext.asynciterable", "dom"],
"lib": ["es2015", "es2016", "es2017", "esnext.string","esnext.array", "esnext.asynciterable", "dom"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify that we polyfill these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everything, but I tested replaceAll. What else should I look for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we basically need to make sure that it works in any browser we support (not just local) - so either it's been implemented in all that we support, or safer - that core-js polyfills replaceall (I think that's all that comes in here, right?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that I did check.

We are good on all modern browsers.

https://caniuse.com/?search=replaceAll

"paths": {
"@hypertrace/assets-library": ["projects/assets-library/src/public-api.ts"],
"@hypertrace/common": ["projects/common/src/public-api.ts"],
Expand Down