Skip to content

Conversation

@usmansaleem
Copy link
Member

PR description

Add Ethereum execution spec test to be generated and executed by reference tests gradle task. Add https://github.com/ethereum/execution-spec-tests/releases as gradle repository to easily download and cache the test specs. Update the reference test gradle file to generate the test Java classes.

Fixed Issue(s)

#4934

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

@usmansaleem usmansaleem self-assigned this Feb 28, 2023
@usmansaleem usmansaleem added mainnet TeamGroot GH issues worked on by Groot Team and removed TeamGroot GH issues worked on by Groot Team labels Feb 28, 2023
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting code comments in!

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem enabled auto-merge (squash) March 1, 2023 05:16
@usmansaleem usmansaleem merged commit b0daf14 into hyperledger:main Mar 1, 2023
@usmansaleem usmansaleem deleted the withdrawls_execution_tests branch March 1, 2023 05:37
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
Added Ethereum execution spec test to be generated and executed by reference tests gradle task. Add `https://github.com/ethereum/execution-spec-tests/releases` as custom ivy repository to easily download and cache the test specs. Updated the reference test gradle file to generate the test Java classes.

Signed-off-by: Usman Saleem <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Added Ethereum execution spec test to be generated and executed by reference tests gradle task. Add `https://github.com/ethereum/execution-spec-tests/releases` as custom ivy repository to easily download and cache the test specs. Updated the reference test gradle file to generate the test Java classes.

Signed-off-by: Usman Saleem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants