EVM Tool state-test should ignore previousHash in lookups #5126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
BlockHashLookup to CachingBlockHashLookup Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
siladu
approved these changes
Feb 24, 2023
Contributor
siladu
left a comment
siladu
left a comment
There was a problem hiding this comment.
Enjoyed reading the Java > 11 code :)
|
|
||
| final WorldUpdater worldStateUpdater = worldState.updater(); | ||
| final BlockHashLookup blockHashLookup = new BlockHashLookup(blockHeader, blockchain); | ||
| final BlockHashLookup blockHashLookup = new CachingBlockHashLookup(blockHeader, blockchain); |
Contributor
There was a problem hiding this comment.
The scope of these changes make me a little nervous but I realise it is essentially just a rename, so should be good.
Contributor
Author
There was a problem hiding this comment.
Yea, either we rename the implementation or we rename the type. I went with the impl on the basis the impl can describe how it implements the interface. i.e. List / ArrayList.
| mutableWorldState, | ||
| transactionProcessor)) | ||
| .collect(Collectors.toList()); | ||
| .toList(); |
Comment on lines
+54
to
+55
| } else if (chainedUpdater instanceof StackedUpdater<?, ?> stackedUpdater) { | ||
| stackedUpdater.markTransactionBoundary(); |
Use the specified BlockHashes in t8n Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .map( | ||
| entry -> | ||
| Map.entry( | ||
| Long.decode(entry.getKey()), Hash.fromHexString(entry.getValue()))) |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
Support two in-the-wild models of blockhash for testing. For state-tests always use the keccak hash of the decimal text of the block number. For t8n always use the blockHashes table in the env. No change to production handling of blockhash. Refactored BlockHashLookup to split caching implementation from API. Signed-off-by: Danno Ferrin <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Support two in-the-wild models of blockhash for testing. For state-tests always use the keccak hash of the decimal text of the block number. For t8n always use the blockHashes table in the env. No change to production handling of blockhash. Refactored BlockHashLookup to split caching implementation from API. Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The EVMTool State test needs to ignore the
previosHashfield when it comes to calculating BlockHashes, and instead follow the reference test rule that the hash is the Keccack hash of the base-10 ascii number.To "do it right" this involved refactoring BlockHashLookup to not drag along some caching rules.
Fixed Issue(s)
Fixes #5122
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog