trigger heal in case of bad code #5103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <[email protected]>
garyschulte
reviewed
Feb 16, 2023
| if (localCode == null) { | ||
| return wrappedWorldView().getCode(address, codeHash); | ||
| final Optional<Bytes> code = wrappedWorldView().getCode(address, codeHash); | ||
| if (code.isEmpty() && !codeHash.equals(Hash.EMPTY)) { |
Contributor
There was a problem hiding this comment.
should this instead hash code and compare it to codeHash rather than just checking empty? or is the hashing prohibitively expensive
Contributor
Author
There was a problem hiding this comment.
Yes this is enough because the hash check is already done at the storage level. And if it is not good we will have an Empty. So I prefer to avoid adding an unnecessary extra shot for this check
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Mar 6, 2023
Signed-off-by: Karim TAAM <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Karim TAAM <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Karim TAAM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog