Add max_fee_per_data_gas field to transaction #4970
Conversation
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public static void writeBlobVersionedHashes( | ||
| final RLPOutput rlpOutput, final List<Hash> versionedHashes) { |
Check notice
Code scanning / CodeQL
Useless parameter
| } | ||
|
|
||
| public static void writeBlobVersionedHashes( | ||
| final RLPOutput rlpOutput, final List<Hash> versionedHashes) { |
Check notice
Code scanning / CodeQL
Useless parameter
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
# Conflicts: # ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/BlockDataGenerator.java # evm/src/main/java/org/hyperledger/besu/evm/frame/MessageFrame.java
| Optional.empty(), | ||
| Optional.empty(), | ||
| unsignedLong(gas), | ||
| Optional.ofNullable(address(toAddress)), |
There was a problem hiding this comment.
is it normal to remove the optional for the to address ?
There was a problem hiding this comment.
yes because it is done in the TransactionBuilder
| private Multimap<Address, Bytes32> accessListWarmStorage = HashMultimap.create(); | ||
|
|
||
| private Optional<List<Hash>> versionedHashes; | ||
|
|
There was a problem hiding this comment.
we can remove this modification
There was a problem hiding this comment.
it is voluntary, to add a missing space to separate 2 methods
|
|
||
| public static final BigInteger TWO = BigInteger.valueOf(2); | ||
|
|
||
| public static final int DATA_GAS_PER_BLOB = 131072; // 2^17 |
There was a problem hiding this comment.
maybe a good idea to move that in the protocol schedule part in a future PR
There was a problem hiding this comment.
I agree, and will remove it from this review, since it will go in the data gas accounting PR
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public BlockOptions setMaxFeePerDataGas(final Optional<Wei> maxFeePerDataGas) { | ||
| this.maybeMaxFeePerDataGas = Optional.of(maxFeePerDataGas); |
There was a problem hiding this comment.
is this optional of optional?
There was a problem hiding this comment.
I followed the same pattern that was used for the optional baseFee, that is also optional of optional here
There was a problem hiding this comment.
yeah I saw that. it's confusing though!
it depends on the protocol schedule, and will managed in a next PR. Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
4 participants
Signed-off-by: Fabio Di Fabio [email protected]
PR description
Fixed Issue(s)
Add max_fee_per_data_gas field to transaction
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog