Update SLF4J version #4587
Merged
Update SLF4J version #4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceCall.java
Fixed
Show fixed
Hide fixed
.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceCallMany.java
Fixed
Show fixed
Hide fixed
.../org/hyperledger/besu/ethereum/eth/transactions/sorter/BaseFeePendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceCall.java
Fixed
Show fixed
Hide fixed
diega
force-pushed
the
slf4j_bump
branch
2 times, most recently
from
d068da3 to
a52aef6
Compare
.../api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceCall.java
Fixed
Show fixed
Hide fixed
diega
force-pushed
the
slf4j_bump
branch
4 times, most recently
from
7313231 to
ad5e612
Compare
shemnon
approved these changes
Feb 23, 2023
Contributor
shemnon
left a comment
shemnon
left a comment
There was a problem hiding this comment.
LGTM. The movement to non-lambda fields/parameters/variables is optional.
...edger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadBodiesByRangeV1.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
Signed-off-by: Diego López León <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Bump SLF4J version and replace helper for lambdas Signed-off-by: Diego López León <[email protected]> * Remove unnecessary toString calls Signed-off-by: Diego López León <[email protected]> * Replace unnecessaryy lambdas for constant references Signed-off-by: Diego López León <[email protected]> --------- Signed-off-by: Diego López León <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Bump SLF4J version and replace helper for lambdas Signed-off-by: Diego López León <[email protected]> * Remove unnecessary toString calls Signed-off-by: Diego López León <[email protected]> * Replace unnecessaryy lambdas for constant references Signed-off-by: Diego López León <[email protected]> --------- Signed-off-by: Diego López León <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update SLF4J version to
2.0.6matching the corresponding bindings for Log4j2. Also, I removed theo.h.b.u.Slf4jLambdaHelperusing new idiomatics for dealing with lambda expressions as logging arguments.This is medium sized PR, but it's composed of syntactic changes mostly performed using automated tools.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog
Signed-off-by: Diego López León [email protected]