Skip to content

Update release workflow with permissions and Node.js version #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update release workflow with permissions and Node.js version #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
783e2f5
Update release workflow with permissions and Node.js version
jwagantall Oct 3, 2025
fee3de3
Change Node.js version from 22 to 20
jwagantall Oct 3, 2025
e82d777
Update npm installation command for versioning
jwagantall Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,28 @@ jobs:
release-stable:
runs-on: ubuntu-24.04
name: Release Stable
permissions:
contents: write
id-token: write # Required for npm trusted publishing
outputs:
published: ${{ steps.changesets.outputs.published }}
steps:
- name: Checkout Repo
uses: actions/checkout@v4

- uses: pnpm/action-setup@v4

- name: Setup NodeJS
uses: actions/setup-node@v4
with:
node-version: 22
cache: "pnpm"
registry-url: "https://registry.npmjs.org"

# Ensure npm >= 11.5.1 for trusted publishing support.
# Automatically fetch future security updates
- name: Update npm
run: npm install -g npm@^11.5.1

- name: Install Dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -37,7 +47,6 @@ jobs:
version: pnpm changeset-version
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Get current package version
id: get_version
Expand All @@ -54,32 +63,32 @@ jobs:
name: Release Unstable
needs: release-stable
if: always() && github.event_name == 'push' && needs.release-stable.outputs.published == 'false'
permissions:
contents: write
id-token: write # Required for npm trusted publishing
steps:
- name: Checkout Repo
uses: actions/checkout@v4

- uses: pnpm/action-setup@v4

- name: Setup NodeJS
uses: actions/setup-node@v4
with:
node-version: 20
cache: "pnpm"
registry-url: "https://registry.npmjs.org"

# Ensure npm >= 11.5.1 for trusted publishing support
- name: Update npm
run: npm install -g [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we install it as @^11.5.1 so we get (security) updates

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimoGlastra , thank you for your comment. I am ok with it if the maintainers agree.
I pinned the version for reproducibility and to avoid sudden breakages but i am ok if you want to catch future security updates.
I will make the change and let others comment.


- name: Install Dependencies
run: pnpm install --frozen-lockfile

- name: Creating .npmrc
run: |
cat << EOF > ".npmrc"
//registry.npmjs.org/:_authToken=$NPM_TOKEN
EOF
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Create unstable release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
# this ensures there's always a patch release created
cat << 'EOF' > .changeset/snapshot-template-changeset.md
Expand Down