Fix graceful shutdown for Http(1|2)Builder #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `Http1Builder::serve_connection` and `Http2Builder::serve_connection` didn't return `Connection` it was impossible to use them in combination with `Connection::graceful_shutdown`. By returning the Connection future rather than awaiting it, this becomes possible.
k0nserv
force-pushed
the
fix-graceful-shutdown
branch
from
2569317 to
e4e3f01
Compare
|
This was done in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Http1Builder::serve_connectionandHttp2Builder::serve_connectiondidn't returnConnectionit wasimpossible to use them in combination with
Connection::graceful_shutdown.By returning the Connection future rather than awaiting it, this becomes
possible.