feature: make possible to set port number in Uri::builder #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
requested changes
May 19, 2020
Dushistov
force-pushed
the
uri-port
branch
2 times, most recently
from
47f4584 to
4286735
Compare
|
@seanmonstar I fixed all issues that you mentioned. |
|
@seanmonstar, friendly ping. |
|
@seanmonstar, friendly ping! |
1 similar comment
|
@seanmonstar, friendly ping! |
Dushistov
added a commit
to Dushistov/couchbase-lite-rust
that referenced
this pull request
Aug 7, 2020
the current release of tokio-tungstenite contains all suitable fixes add notes about hyperium/http#422 rust-lang/cmake-rs#96 rust-lang/cmake-rs#101
|
Rebase against current master |
|
Close in favor of #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make possible to set port number in
Uri::builder.I work with external API that gives me:
- scheme;
- hostname;
- port;
- path;
It is inconvenient to use format/write macros instead of just call builder method.
ref #206