Support specifying inactive dates #395
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying dates that should be rendered and treated as inactive (unselectable) in the calendar widget.
- Introduces a new
inactiveDatesproperty with a default empty list - Updates day rendering and tap handling to respect
inactiveDates - Adds a
DateTime.isSameDayextension to compare dates without time components
Comments suppressed due to low confidence (2)
lib/flutter_calendar_carousel.dart:128
- Public API fields like
inactiveDatesshould have doc comments explaining their purpose and behavior (e.g., how dates are matched and what rendering changes occur).
final List<DateTime> inactiveDates;
lib/flutter_calendar_carousel.dart:871
- The new inactive-date blocking logic in
_onDayPressedshould have corresponding unit or widget tests to verify that taps on inactive dates do not select those days.
if (widget.inactiveDates.any(
lib/flutter_calendar_carousel.dart
Outdated
| } else if (widget.inactiveDates.any( | ||
| (final DateTime inactiveDate) => | ||
| inactiveDate.isSameDay(now), | ||
| )) { | ||
| isSelectable = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
The inactiveDates.any(...) check is duplicated in multiple rendering branches. Consider extracting this into a helper method (e.g. bool _isInactive(DateTime day)) to reduce duplication and improve readability.
| } else if (widget.inactiveDates.any( | |
| (final DateTime inactiveDate) => | |
| inactiveDate.isSameDay(now), | |
| )) { | |
| isSelectable = false; | |
| } | |
| } else if (_isInactive(now)) { |
There was a problem hiding this comment.
addressed this in 0f997ca
lib/flutter_calendar_carousel.dart
Outdated
| } else if (now.millisecondsSinceEpoch > | ||
| maxDate.millisecondsSinceEpoch) { | ||
| isSelectable = false; | ||
| } else if (widget.inactiveDates.any( |
There was a problem hiding this comment.
Using List.any for each day render can be O(n) per cell; if inactiveDates grows large, consider storing dates in a Set or hashing normalized date keys for constant-time lookups.
There was a problem hiding this comment.
not going to address this
|
This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days |
|
@hyochan sorry for the lengthly delay. I've replied to the Copilot's review. Would you mind taking an another look at the PR? |
2 participants
Non-breaking change
Closes #381
Closes #286