-
Notifications
You must be signed in to change notification settings - Fork 326
Add ability to upper case week days text by setting upperCaseWeekDays
#392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that while providing a CustomWeekdayBuilder to build Weekdays in a different form is useful, adding upperCaseWeekDays for simpler modifications is a good idea. However, it might be clearer if an enum type that supports this kind of formatting were provided as well. Additionally, I think it would be helpful to explicitly state that the priority of this approach is lower than that of CustomWeekdayBuilder. What are your thoughts on this?
Are you talking about including it in the
Absolutely agree on that one |
In this case |
|
This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days |
|
The PR is not stale! |
|
This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days |
|
Still planning on continuing this some time later |
Non-breaking change
Adds support for an optional parameter
upperCaseWeekDays, which makes weekDays text uppercase