Skip to content

Conversation

@vanyasem
Copy link
Contributor

Non-breaking change
Adds support for an optional parameter upperCaseWeekDays, which makes weekDays text uppercase

@hyochan hyochan added the enhancement New feature or request label Mar 19, 2025
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that while providing a CustomWeekdayBuilder to build Weekdays in a different form is useful, adding upperCaseWeekDays for simpler modifications is a good idea. However, it might be clearer if an enum type that supports this kind of formatting were provided as well. Additionally, I think it would be helpful to explicitly state that the priority of this approach is lower than that of CustomWeekdayBuilder. What are your thoughts on this?

@vanyasem
Copy link
Contributor Author

@hyochan

an enum type that supports this kind of formatting were provided as well

Are you talking about including it in the WeekdayFormat enum, or about creating a new enum to specify weekday styling?

I think it would be helpful to explicitly state that the priority of this approach is lower

Absolutely agree on that one

@hyochan
Copy link
Owner

hyochan commented Mar 20, 2025

@hyochan

an enum type that supports this kind of formatting were provided as well

Are you talking about including it in the WeekdayFormat enum, or about creating a new enum to specify weekday styling?

I think it would be helpful to explicitly state that the priority of this approach is lower

Absolutely agree on that one

In this case a new enum to specify weekday styling and wanted to hear your thought!

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days

@vanyasem
Copy link
Contributor Author

The PR is not stale!
I will get back to it some time in the following month
Haven't had much free time lately

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days

@vanyasem
Copy link
Contributor Author

Still planning on continuing this some time later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants