-
-
Notifications
You must be signed in to change notification settings - Fork 77
Windows support #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Windows support #747
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 84.29% 83.73% -0.57%
==========================================
Files 117 117
Lines 7726 5993 -1733
==========================================
- Hits 6513 5018 -1495
+ Misses 1213 975 -238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'RouterRouter:Echo metricsMalloc (total): results within specified thresholds, fold down for details.
Router:GET metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
Router:PUT metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
RouterBuilder:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:LongPaths metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Routing metricsMalloc (total): results within specified thresholds, fold down for details.
|
adam-fowler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is just disabling file operations. I would move to NIOFileSystem but it is still prefixed with an _ indicating it is not final release and breaking changes maybe included. Although now Vapor have moved that seems unlikely.
Can you chase NIO guys about state of release and what their recommendation is. I want them to commit to an fixed API before moving.
|
I’m also curious about the current state of NIO FS. We’re considering using it in the long run. |
|
I'll chase up in the SSWG tonight |
Adds support to run on Windows platforms.
Depends on:
ucrton Windows if available apple/swift-nio-extras#294Notes