-
Notifications
You must be signed in to change notification settings - Fork 31.1k
Create test for #38916 (custom generate from local dir with imports) #39015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manueldeprada
merged 3 commits into
huggingface:main
from
manueldeprada:local-custom-gen-tests
Jun 26, 2025
Merged
Create test for #38916 (custom generate from local dir with imports) #39015
manueldeprada
merged 3 commits into
huggingface:main
from
manueldeprada:local-custom-gen-tests
Jun 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe cool test! Thank you for adding it :D
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…h imports) (huggingface#39015) * create test for huggingface#38916 (custom generate from local dir with imports)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38916 was missing a test. We check that custom generate from a local dir with relative imports works properly.
The test is not conventional, so I appreciate the review :)