Skip to content

[tokenizer] sanitize saved config #21483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2023
Merged

[tokenizer] sanitize saved config #21483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b15ec9
[tokenizer] sanitize saved config
stas00 Feb 7, 2023
1bbcc84
rm config["name_or_path"] test
stas00 Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/transformers/tokenization_utils_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2154,6 +2154,10 @@ def convert_added_tokens(obj: Union[AddedToken, Any], add_type_field=True):
if self._auto_class is not None:
custom_object_save(self, save_directory, config=tokenizer_config)

# remove private information
if "name_or_path" in tokenizer_config:
tokenizer_config.pop("name_or_path")

with open(tokenizer_config_file, "w", encoding="utf-8") as f:
out_str = json.dumps(tokenizer_config, indent=2, sort_keys=True, ensure_ascii=False) + "\n"
f.write(out_str)
Expand Down
2 changes: 0 additions & 2 deletions tests/models/auto/test_tokenization_auto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ def test_get_tokenizer_config(self):

# Check the class of the tokenizer was properly saved (note that it always saves the slow class).
self.assertEqual(config["tokenizer_class"], "BertTokenizer")
# Check other keys just to make sure the config was properly saved /reloaded.
self.assertEqual(config["name_or_path"], SMALL_MODEL_IDENTIFIER)

def test_new_tokenizer_registration(self):
try:
Expand Down