Skip to content

Disable decoder_input_details on OpenAI-compatible chat streaming, pass temp and top-k from API #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Disable decoder_input_details on OpenAI-compatible chat streaming, pass temp and top-k from API #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4347960
Disable decoder_input_details for streaming requests
EndlessReform Jan 23, 2024
d805612
Transparently pass through temp and top_p
EndlessReform Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions router/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,18 @@ pub(crate) struct ChatRequest {

#[schema(nullable = true, example = 42)]
pub seed: Option<u64>,

/// What sampling temperature to use, between 0 and 2. Higher values like 0.8 will make the output more random, while
/// lower values like 0.2 will make it more focused and deterministic.
///
/// We generally recommend altering this or `top_p` but not both.
#[serde(default)]
pub temperature: Option<f32>,

/// An alternative to sampling with temperature, called nucleus sampling, where the model considers the results of the
/// tokens with top_p probability mass. So 0.1 means only the tokens comprising the top 10% probability mass are considered.
#[serde(default)]
pub top_p: Option<f32>,
}

#[derive(Clone, Serialize, Deserialize)]
Expand Down
6 changes: 3 additions & 3 deletions router/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,10 @@ async fn chat_completions(
inputs: inputs.to_string(),
parameters: GenerateParameters {
best_of: None,
temperature: None,
temperature: req.temperature,
repetition_penalty,
top_k: None,
top_p: None,
top_p: req.top_p,
typical_p: None,
do_sample: true,
max_new_tokens,
Expand All @@ -604,7 +604,7 @@ async fn chat_completions(
truncate: None,
watermark: false,
details: true,
decoder_input_details: true,
decoder_input_details: !stream,
seed,
top_n_tokens: None,
},
Expand Down