-
Notifications
You must be signed in to change notification settings - Fork 371
Propagate vLLM batch size controls #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Only need to make sure that when the user does not specifiy we use the defaults used by vllm
|
@NathanHB should be ready for another round of review! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@NathanHB thanks for the review! should I merge this now? |
* expose vLLM batch size control config * comments * type casting * bump * fix defaults
* expose vLLM batch size control config * comments * type casting * bump * fix defaults
Description
In this PR, we fixed issue #573 by propagating the batch size control parameters to
VLLMModelConfig. For more detailed explanation of their batch size parameters, see vllm-project/vllm#2492.Testing
I ran the following CLI commands to invoke a simple evaluation job. Based on the results, we can see that controlling
max_num_seqswill determine the batch size at the pre-filling stage, thus impacting the throughput of the model, i.e., 1m4s withmax_num_seqs=256(which is the default) vs. 3m15s withmax_num_seqs=1. I'm testing this with an AWS instance ofg6e.xlarge.Default
BS=1