Update arabic_evals.py: Fix custom arabic tasks [2nd attempt] #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix alghafa prompt function by explicitly determining the list of choices based on task_name. Not all subsets of AlGhafa Native share same columns
clefourrier
reviewed
Dec 12, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Clémentine Fourrier <[email protected]>
Fix to `KeyError: 'sol3'` and `TypeError: Doc.__init__() got an unexpected keyword argument 'target_for_fewshot_sorting'`
|
Ready to be merged [√] KeyError: 'sol3'And: TypeError: Doc.__init__() got an unexpected keyword argument 'target_for_fewshot_sorting' |
|
@clefourrier I believe this PR is ready to be merged and it is tested 👍 |
|
Yep, will merge as soon as tests pass ^^ thanks for the ping! |
|
@alielfilali01 you'll need to make sure code qual passes |
|
Damn i keep forgetting that 🥲 sorry will run it later ounce i can ! Thanks @clefourrier |
NathanHB
approved these changes
Dec 19, 2024
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
Fix alghafa prompt function by explicitly determining the list of choices based on task_name. (Not all subsets of AlGhafa Native share same columns) --------- Co-authored-by: Clémentine Fourrier <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
Fix alghafa prompt function by explicitly determining the list of choices based on task_name. (Not all subsets of AlGhafa Native share same columns) --------- Co-authored-by: Clémentine Fourrier <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix alghafa prompt function by explicitly determining the list of choices based on task_name.
(Not all subsets of AlGhafa Native share same columns)
cc: @clefourrier