Skip to content

Fix ignored reuse_existing in config file #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Fix ignored reuse_existing in config file #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01db164
Align should_reuse_existing with reuse_existing
albertvillanova Dec 10, 2024
c2b5528
Align reuse_existing default to False
albertvillanova Dec 10, 2024
00fa86e
Merge branch 'main' into fix-should-reuse-existing
albertvillanova Dec 10, 2024
5c174d0
Merge branch 'main' into fix-should-reuse-existing
albertvillanova Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lighteval/main_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def inference_endpoint(
"endpoint_name": config["base_params"].get("endpoint_name", None),
"model_dtype": config["base_params"].get("dtype", None),
"revision": config["base_params"].get("revision", None) or "main",
"should_reuse_existing": config["base_params"].get("should_reuse_existing"),
"reuse_existing": config["base_params"].get("reuse_existing"),
"accelerator": config.get("instance", {}).get("accelerator", None),
"region": config.get("instance", {}).get("region", None),
"vendor": config.get("instance", {}).get("vendor", None),
Expand Down
8 changes: 4 additions & 4 deletions src/lighteval/models/endpoints/endpoint_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class InferenceModelConfig:
class InferenceEndpointModelConfig:
endpoint_name: str = None
model_name: str = None
should_reuse_existing: bool = False
reuse_existing: bool = False
accelerator: str = "gpu"
model_dtype: str = None # if empty, we use the default
vendor: str = "aws"
Expand Down Expand Up @@ -135,7 +135,7 @@ class InferenceEndpointModel(LightevalModel):
def __init__( # noqa: C901
self, config: Union[InferenceEndpointModelConfig, InferenceModelConfig], env_config: EnvConfig
) -> None:
self.reuse_existing = getattr(config, "should_reuse_existing", True)
self.reuse_existing = getattr(config, "reuse_existing", False)
self._max_length = None
self.endpoint = None
self.model_name = None
Expand Down Expand Up @@ -171,7 +171,7 @@ def __init__( # noqa: C901
):
try:
if self.endpoint is None: # Endpoint does not exist yet locally
if not config.should_reuse_existing: # New endpoint
if not config.reuse_existing: # New endpoint
logger.info("Creating endpoint.")
self.endpoint: InferenceEndpoint = create_inference_endpoint(
name=endpoint_name,
Expand Down Expand Up @@ -239,7 +239,7 @@ def __init__( # noqa: C901
# The endpoint actually already exists, we'll spin it up instead of trying to create a new one
if "409 Client Error: Conflict for url:" in str(e):
config.endpoint_name = endpoint_name
config.should_reuse_existing = True
config.reuse_existing = True
# Requested resources are not available
elif "Bad Request: Compute instance not available yet" in str(e):
logger.error(
Expand Down
Loading