Fixes a TypeError in Sacrebleu. #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Nov 12, 2024
clefourrier
reviewed
Nov 12, 2024
clefourrier
approved these changes
Nov 14, 2024
|
You'll need to run the ruff styling :) |
|
Hi! I edited the readme to make the styling steps clearer, you'll need to run |
hynky1999
pushed a commit
that referenced
this pull request
Nov 29, 2024
--------- Co-authored-by: Clémentine Fourrier <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
--------- Co-authored-by: Clémentine Fourrier <[email protected]>
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
--------- Co-authored-by: Clémentine Fourrier <[email protected]>
NathanHB
pushed a commit
that referenced
this pull request
Sep 19, 2025
--------- Co-authored-by: Clémentine Fourrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SacreBleu expects the hypotheses to be a list of strings. We gave a list of list of strings which leads to a TypeError. I flattened the list to fix this.