Skip to content

Nanotron greedy_until() fix #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Nanotron greedy_until() fix #344

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f4aab7
greedy_until() fix
vsabolcec Oct 4, 2024
a65722e
Merge branch 'main' into nanotron_greedyuntil_fix
NathanHB Oct 4, 2024
e461548
Merge branch 'main' into nanotron_greedyuntil_fix
NathanHB Oct 7, 2024
df7aa59
Merge branch 'main' into nanotron_greedyuntil_fix
NathanHB Oct 8, 2024
fe31254
Merge branch 'main' into nanotron_greedyuntil_fix
clefourrier Nov 8, 2024
63aaad5
Merge branch 'main' into nanotron_greedyuntil_fix
clefourrier Nov 8, 2024
cdd05b9
Merge branch 'main' into nanotron_greedyuntil_fix
clefourrier Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lighteval/models/nanotron_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ def greedy_until(
else:
# Longest context in the current split is the first item (since we sort reversed)
context_enc = dataset[0][1].tokenized_context
max_gen = max(item[1].generation_size for item in dataset)
max_gen = max(item.generation_size for item in dataset)
max_input_length = min(len(context_enc) + max_gen, self.max_length)

batch_size = self._get_batch_size(
Expand Down
Loading