[Inference] Add async polling support for Replicate provider #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucataco
requested review from
SBrandeis,
hanouticelina and
julien-c
as code owners
| const prediction = (await pollResponse.json()) as ReplicateAsyncResponse; | ||
| const predictionStatus = prediction.status; | ||
|
|
||
| if (!predictionStatus || predictionStatus === "succeeded") { |
There was a problem hiding this comment.
is it intentional to treat "no status" as a successful response?
There was a problem hiding this comment.
I think we have to remove Prefer: wait from the headers (defined in prepareHeaders) now that all the tasks are using async polling
| output?: string | string[]; | ||
| } | ||
|
|
||
| type ReplicatePredictionStatus = "starting" | "processing" | "succeeded" | "failed" | "canceled" | "queued"; |
There was a problem hiding this comment.
i believe this gives tighter typings and better autocomplete support
Suggested change
| type ReplicatePredictionStatus = "starting" | "processing" | "succeeded" | "failed" | "canceled" | "queued"; | |
| const REPLICATE_STATUSES = [ | |
| "starting", | |
| "processing", | |
| "succeeded", | |
| "failed", | |
| "canceled", | |
| "queued", | |
| ] as const; | |
| type ReplicatePredictionStatus = (typeof REPLICATE_STATUSES)[number]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds async polling for Replicate
To help the huggingface team so that they no longer need an allow-list of Replicate models to show Hub users
@SBrandeis