[LoRA] make set_adapters() method more robust. #9535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Failing tests are completely unrelated. |
| check_if_lora_correctly_set(pipe.text_encoder_2), "Lora not correctly set in text encoder 2" | ||
| ) | ||
|
|
||
| with self.assertRaises(ValueError) as err_context: |
There was a problem hiding this comment.
Could use self.assertRaisesRegex to directly check the error message.
There was a problem hiding this comment.
We just prefer to do a bit more explicitly across the codebase (which is what I have followed here).
BenjaminBossan
approved these changes
Sep 26, 2024
Co-authored-by: YiYi Xu <[email protected]>
This was referenced Oct 7, 2024
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
* make set_adapters() method more robust. * remove patch * better and concise code. * Update src/diffusers/loaders/lora_base.py Co-authored-by: YiYi Xu <[email protected]> --------- Co-authored-by: YiYi Xu <[email protected]>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* make set_adapters() method more robust. * remove patch * better and concise code. * Update src/diffusers/loaders/lora_base.py Co-authored-by: YiYi Xu <[email protected]> --------- Co-authored-by: YiYi Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First caught in #9525 (comment) by @asomoza. But then it turned out to be #9525 (comment).
This PR:
set_adapters()method more robust by catching errors on adapter names that are wrong (and adds a test for it).set_adapters()more robust.@cshowley do you wanna give this a try?