Skip to content

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Feb 13, 2024

What does this PR do?

Similar fix to : #6950

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Comment on lines +41 to +43
config_file (`str`, *optional*):
Filepath to the configuration YAML file associated with the model. If not provided it will default to:
https://raw.githubusercontent.com/lllyasviel/ControlNet/main/models/cldm_v15.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes the difference between original_config_file and config_file quite clear. Could you rephrase?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They both mean the same thing. We used original_config_file in the pipeline Mixin.

With the refactor, the internal logic config_file = kwargs.pop("config_file") was removed in favour of using original_config_file like we do for the Pipelines.

But UI's like SD.Next use config_file when loading the VAE. Putting it back here again for backwards compatibility.

We don't need to keep both. We can deprecate one of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Then maybe in a follow-up PR, let's start their deprecation cycles?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 merged commit 3cf4f9c into main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants